-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 74.0.3729.131 to Chromium 74.0.3729.157 #4452
Conversation
CI to watch: https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-4452/1/ NOTE: remove temp commit before merging |
Getting an error on this one:
|
Issue found 😄Needed to pull in new strings per https://github.com/brave/brave-browser/wiki/Chromium-rebases#fix-strings |
I suspect Jenkins had old workspace filed cached; restarted job with https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-4452/3/ If this passes, we should be good to merge! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Windows had a browser test failure during initial run; I replayed just Windows and it worked great on second try 😄 Merging! |
Fixes #4443
Related brave/brave-core#2448
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.