Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix product_logo in chrome://versions and default_browser_infobar #520

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Fix product_logo in chrome://versions and default_browser_infobar #520

merged 2 commits into from
Jul 11, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jul 11, 2018

Fix #519
Please see brave/brave-core#240 for more info.
Will need to be merged together with above.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@yrliou yrliou self-assigned this Jul 11, 2018
@yrliou yrliou changed the title Fix product_logo in chrome://versions and infobar Fix product_logo in chrome://versions and default_browser_infobar Jul 11, 2018
AlexeyBarabash
AlexeyBarabash approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy added this to the Releasable builds milestone Jul 11, 2018
@bbondy bbondy merged commit f145787 into master Jul 11, 2018
@yrliou yrliou deleted the update_product_logos branch July 11, 2018 18:48
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@yrliou @AlexeyBarabash @bbondy