-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MacOS notarization #5485
Merged
Merged
Add MacOS notarization #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing milestone as this is not reviewed/approved/merged 👍 |
mbacchi
force-pushed
the
issue_5177
branch
2 times, most recently
from
October 3, 2019 13:04
73b812a
to
ac35737
Compare
bsclifton
reviewed
Oct 18, 2019
mihaiplesa
previously approved these changes
Oct 23, 2019
bsclifton
previously approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
32 tasks
mihaiplesa
previously approved these changes
Oct 30, 2019
Fixes: #5177
mihaiplesa
force-pushed
the
issue_5177
branch
from
October 30, 2019 16:44
3ed7a37
to
2403282
Compare
4 tasks
4 tasks
mbacchi
added a commit
that referenced
this pull request
Nov 1, 2019
4 tasks
4 tasks
bsclifton
added a commit
that referenced
this pull request
Nov 4, 2019
Add MacOS notarization (Uplift of #5485 to 0.72.x)
bsclifton
added a commit
that referenced
this pull request
Nov 4, 2019
Add MacOS notarization (Uplift of #5485 to 0.71.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
Depends upon changes in brave-core branch
issue_5177
.Requires NPM configuration such as:
Fixes: #5177
Related: brave/brave-core#3725
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.