Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace incognito marker svg file #5671

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 15, 2019

fix #5368

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 0.71.x - Nightly milestone Aug 15, 2019
@simonhong simonhong self-assigned this Aug 15, 2019
@bsclifton
Copy link
Member

Removing milestone as this is not reviewed/approved/merged 👍

@bsclifton bsclifton removed this from the 0.71.x - Dev milestone Sep 12, 2019
@petemill
Copy link
Member

petemill commented Dec 2, 2019

@simonhong is this neccessary / ready? Only asking since it is marked as 'draft' still.

@simonhong
Copy link
Member Author

@petemill I had an issue with brave/brave-core#3188.
As you can see in the captured image, new svg file is not rendered properly.
Can you help to find the reason why it's not rendered properly? :)

@simonhong simonhong force-pushed the incognito_marker_in_downloads_page branch from 7aae934 to 667eaba Compare January 10, 2020 05:30
@simonhong simonhong force-pushed the incognito_marker_in_downloads_page branch from 667eaba to 60dc1aa Compare January 23, 2020 02:21
@simonhong simonhong added this to the 1.5.x - Nightly milestone Jan 23, 2020
@simonhong simonhong force-pushed the incognito_marker_in_downloads_page branch from 60dc1aa to 92d56b4 Compare January 23, 2020 02:26
@simonhong simonhong marked this pull request as ready for review January 23, 2020 02:26
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! ++

@bsclifton bsclifton merged commit 51210b7 into master Jan 23, 2020
@bsclifton bsclifton deleted the incognito_marker_in_downloads_page branch January 23, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium incognito icons used in Private and Tor window for downloads
3 participants