Add support for Android unittests #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
force-pushed
the
android_unittests
branch
from
e5214f9 to
d342686
Compare
32 tasks
bbondy
force-pushed
the
android_unittests
branch
2 times, most recently
from
509a407 to
9c562d0
Compare
emerick
reviewed
Sep 23, 2019
lib/test.js
Outdated
| @@ -12,6 +12,11 @@ const test = (suite, buildConfig = config.defaultBuildConfig, options) => { | |||
| '--v=' + options.v, | |||
There was a problem hiding this comment.
I think we need to delete the --v argument here, right?
There was a problem hiding this comment.
Yep sorry I had re-added it to test and make sure I wasn't crazy. Fixed now.
bbondy
force-pushed
the
android_unittests
branch
2 times, most recently
from
20bbc56 to
39d36a2
Compare
brave-builds
force-pushed
the
android_unittests
branch
from
39d36a2 to
709329c
Compare
bbondy
force-pushed
the
android_unittests
branch
2 times, most recently
from
3548fd1 to
22e0a87
Compare
bbondy
force-pushed
the
android_unittests
branch
from
22e0a87 to
3d83499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6138
Sister PR: brave/brave-core#3514
Documentation added here: https://github.com/brave/brave-browser/wiki/Tests#android
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.