Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #6265

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Create CONTRIBUTING.md #6265

merged 5 commits into from
Oct 31, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 1, 2019

Fixes #108

Easy to read version located here:
https://github.com/brave/brave-browser/blob/bsc-add-contributing-md/CONTRIBUTING.md

Submitter Checklist:

Test Plan:

N/A

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton self-assigned this Oct 1, 2019
@bsclifton bsclifton changed the title Create CONTRIBUTING.md WIP: Create CONTRIBUTING.md Oct 1, 2019
@bsclifton
Copy link
Member Author

Still a WIP - but feedback very welcome!

@pes10k
Copy link
Contributor

pes10k commented Oct 1, 2019

For my two cents, the main things I think that'd be useful to have in a guide (thats not already in the guide) is how to update, apply and rebase the patch set

@jumde
Copy link
Contributor

jumde commented Oct 1, 2019

More:

  1. When/How to patch (#defines in chromium_src)
  2. Subclassing (in chromium_src) vs Patching

@bsclifton bsclifton force-pushed the bsc-add-contributing-md branch from 09b38b4 to e31ac54 Compare October 9, 2019 00:30
@bsclifton bsclifton marked this pull request as ready for review October 9, 2019 00:31
@bsclifton
Copy link
Member Author

bsclifton commented Oct 9, 2019

OK - I think this is finally ready for review! 😄

edit:
Good call, @jumde - will have to add those

@bsclifton bsclifton changed the title WIP: Create CONTRIBUTING.md Create CONTRIBUTING.md Oct 9, 2019
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
bsclifton and others added 2 commits October 28, 2019 08:33
Co-Authored-By: Cezar Augusto <boss@cezaraugusto.net>
@bsclifton
Copy link
Member Author

Comments by @cezaraugusto addressed - ready for re-review 😄

@bsclifton bsclifton merged commit cafe5af into master Oct 31, 2019
@bsclifton bsclifton deleted the bsc-add-contributing-md branch October 31, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide better documentation for onboarding contributors
6 participants