Rename "Bookmarks Bar/bar" to "Bookmarks" (brave-browser) #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
hide-other-bookmarks
branch
3 times, most recently
from
9360be7 to
7b0cb9f
Compare
AlexeyBarabash
previously approved these changes
Oct 10, 2019
32 tasks
petemill
reviewed
Oct 11, 2019
| @@ -149,4 +158,7 @@ const defaultReplacements = [ | |||
| [/(?<!authenticate )people(?! with slow connections?)/g, 'profiles'], | |||
| [/(Person)(?!\w)/g, 'Profile'], | |||
| [/(person)(?!\w)/g, 'profile'], | |||
| [/Bookmarks Bar\n/g, 'Bookmarks\n'], | |||
There was a problem hiding this comment.
nit: couldn't this be done in 1 line by using case-insensitive regex /bookmarks bar\n/gi?
There was a problem hiding this comment.
no because the third one is replaced by bookmarks
bridiver
previously approved these changes
Oct 15, 2019
darkdh
force-pushed
the
hide-other-bookmarks
branch
from
7b0cb9f to
e9eb34a
Compare
28 tasks
bridiver
approved these changes
Oct 16, 2019
darkdh
added a commit
that referenced
this pull request
Jan 22, 2020
28 tasks
darkdh
added a commit
that referenced
this pull request
Jan 28, 2020
darkdh
added a commit
that referenced
this pull request
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by brave/brave-core#3620
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.