Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all strings for l10n #647

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Mark all strings for l10n #647

merged 1 commit into from
Jul 26, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 26, 2018

Fix #645
Fix #646
Fix #475

Also calls out to upload missing strings

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

Fix #645
Fix #646
Fix #475

Also calls out to upload missing strings
@bbondy bbondy self-assigned this Jul 26, 2018
@bbondy bbondy requested a review from emerick July 26, 2018 17:55
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 5b37391 into master Jul 26, 2018
@bbondy bbondy deleted the l10n-fixes branch August 20, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants