Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist DoH servers in the network auditor (brave/brave-browser#1864) #7790

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jan 17, 2020

This is needed before brave/brave-core#4314 can land because the Mac build machines use these OS resolvers:

nameserver 8.8.8.8
nameserver 8.8.4.4
nameserver 1.1.1.1
nameserver 1.0.0.1

Submitter Checklist:

Test Plan:

Nothing to test in here, but it will make the npm run network-audit test pass in brave/brave-core#4314.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

This is needed because the Mac build machines use these OS
resolvers:

    nameserver 8.8.8.8
    nameserver 8.8.4.4
    nameserver 1.1.1.1
    nameserver 1.0.0.1
@fmarier fmarier self-assigned this Jan 17, 2020
@fmarier
Copy link
Member Author

fmarier commented Jan 17, 2020

The CI failure can be ignored according to @bsclifton: https://bravesoftware.slack.com/archives/CA5FPHWLF/p1579288224009000

@fmarier fmarier merged commit 8839b66 into master Jan 17, 2020
@fmarier fmarier deleted the whitelist-build-machine-doh-servers-1864 branch January 17, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants