Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8034: Add Crowd Deny requests to audit whitelist #8035

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix 8034: Add Crowd Deny requests to audit whitelist #8035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/whitelistedUrlPatterns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Before adding to this list, get approval from the security team
module.exports = [
'http://[A-Za-z0-9-\.]+\.gvt1\.com/edgedl/release2/chrome_component/.+', // allowed because it 307's to crlsets.brave.com
'https://[A-Za-z0-9-\.]+\.gvt1\.com/edgedl/release2/chrome_component/.+', // allowed because it 307's to crlsets.brave.com
'http://[A-Za-z0-9-\.]+\.gvt1\.com/edgedl/release2/.+', // allowed because it 307's to redirector.brave.com
'https://[A-Za-z0-9-\.]+\.gvt1\.com/edgedl/release2/.+', // allowed because it 307's to redirector.brave.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i'm not mistaken, this is a superset of the patterns above it, so those patterns can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

'http://www.google.com/dl/release2/chrome_component/.+crl-set.+', // allowed because it 307's to crlsets.brave.com
'https://www.google.com/dl/release2/chrome_component/.+crl-set.+', // allowed because it 307's to crlsets.brave.com
'http://storage.googleapis.com/update-delta/hfnkpimlhhgieaddgfemjhofmfblmnib/.+crxd', // allowed because it 307's to crlsets.brave.com,
Expand Down
5 changes: 3 additions & 2 deletions lib/whitelistedUrlPrefixes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ module.exports = [
'https://update.googleapis.com/service/update2', // allowed because it 307's to go-updater.brave.com. should never actually connect to googleapis.com.
'https://safebrowsing.googleapis.com/v4/threatListUpdates', // allowed because it 307's to safebrowsing.brave.com
'https://clients2.googleusercontent.com/crx/blobs/',
'http://dl.google.com/release2/chrome_component/', // allowed because it 307's to crlset1.brave.com
'https://dl.google.com/release2/chrome_component/', // allowed because it 307's to crlset1.brave.com
'http://dl.google.com/', // allowed because it 307's to redirector.brave.com
'https://dl.google.com/', // allowed because it 307's to redirector.brave.com
'https://no-thanks.invalid/', // fake gaia URL
'https://go-updater.brave.com/',
'https://safebrowsing.brave.com/',
Expand All @@ -30,4 +30,5 @@ module.exports = [
'https://dns.google/dns-query', // needed for DoH on Mac build machines
'https://chrome.cloudflare-dns.com/dns-query', // needed for DoH on Mac build machines
'https://tor.bravesoftware.com/', // for fetching tor client updater component
'https://redirector.brave.com/',
]