Skip to content

Commit

Permalink
//ui/base depends on //chrome/app:generated_resources
Browse files Browse the repository at this point in the history
This fixes an intermittant build error due to the generated_resources being included in web_ui_util (inside the //ui/base project)

A better way would be to refactor so that all our webuis call a helper function to add these generated strings, instead of modifying something that's meant to have no app dependencies (a base project) to depend on some app-specific strings, but this potentially fixes the issues caused by code already in place.
  • Loading branch information
petemill committed May 8, 2019
1 parent 06f0527 commit 154f678
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ui/base/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ group("chromium_deps") {
deps = [
"//brave/ui/webui/resources",
"//brave/app:brave_generated_resources_grit",
"//chrome/app:generated_resources",
]
}

0 comments on commit 154f678

Please sign in to comment.