Merge pull request #10002 from brave/pr9984_issues/17864_1.30.x

Add check if javascript was disallowed. (uplift to 1.30.x)
brave · Sep 9, 2021 · 377cedd · 377cedd
2 parents cc4b335 + 7983d43
commit 377cedd
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/browser/ui/webui/new_tab_page/brave_new_tab_message_handler.cc b/browser/ui/webui/new_tab_page/brave_new_tab_message_handler.cc
@@ -431,6 +431,7 @@ void BraveNewTabMessageHandler::OnJavascriptDisallowed() {
  if (tor_launcher_factory_)
  tor_launcher_factory_->RemoveObserver(this);
 #endif
+ weak_ptr_factory_.InvalidateWeakPtrs();
 }
 
 void BraveNewTabMessageHandler::HandleGetPreferences(
@@ -726,6 +727,11 @@ void BraveNewTabMessageHandler::HandleTodayGetDisplayAd(
  if (!handler) {
  return;
  }
+
+ if (!handler->IsJavascriptAllowed()) {
+ return;
+ }
+
  if (!success) {
  handler->ResolveJavascriptCallback(base::Value(callback_id),
  std::move(base::Value()));