Add learn more link for WebRTC policy setting

brave · Oct 2, 2018 · 3a33d4e · 3a33d4e
1 parent b93f93e
commit 3a33d4e
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/app/brave_generated_resources.grd b/app/brave_generated_resources.grd
@@ -215,6 +215,9 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
       <message name="IDS_SETTINGS_WEBRTC_POLICY_LABEL" desc="WebRTC policy setting label">
         WebRTC IP Handling Policy
       </message>
+      <message name="IDS_SETTINGS_WEBRTC_POLICY_SUB_LABEL" desc="WebRTC policy setting sub-label">
+        Learn more
+      </message>
       <message name="IDS_SETTINGS_WEBRTC_POLICY_DEFAULT" desc="Select value">
         Default
       </message>

diff --git a/browser/resources/settings/brave_privacy_page/brave_personalization_options.html b/browser/resources/settings/brave_privacy_page/brave_personalization_options.html
@@ -9,9 +9,18 @@
 <dom-module id="settings-brave-personalization-options">
   <template>
     <style include="settings-shared md-select iron-flex">
+      .settings-box {
+        display: flex;
+        justify-content: space-between;
+      }
     </style>
     <div class="settings-box">
-      <div class="start">$i18n{webRTCPolicyLabel}</div>
+      <div calss="start" id="labelWrapper">
+        <div class="label">$i18n{webRTCPolicyLabel}</div>
+        <a id="learnMore" href="$i18n{webRTCLearnMoreURL}" target="_blank">
+          $i18n{webRTCPolicySubLabel}
+        </a>
+      </div>
       <select id="webRTCPolicy" class="md-select"
           on-change="onWebRTCPolicyChange_">
         <template is="dom-repeat" items="[[webRTCPolicies_]]">

diff --git a/chromium_src/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chromium_src/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -17,6 +17,9 @@ void BraveAddImportDataStrings(content::WebUIDataSource* html_source) {
 }
 #endif
 
+const char kWebRTCLearnMoreURL[] =
+  "https://github.com/brave/brave-browser/wiki/WebRTC-Custom-Settings";
+
 void BraveAddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {
   LocalizedString localized_strings[] = {
     {"siteSettingsAutoplay",
@@ -61,6 +64,8 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source, Profile* profi
       IDS_SETTINGS_BLOCK_FINGERPRINTING},
     {"webRTCPolicyLabel",
       IDS_SETTINGS_WEBRTC_POLICY_LABEL},
+    {"webRTCPolicySubLabel",
+      IDS_SETTINGS_WEBRTC_POLICY_SUB_LABEL},
     {"webRTCDefault",
       IDS_SETTINGS_WEBRTC_POLICY_DEFAULT},
     {"defaultPublicAndPrivateInterfaces",
@@ -72,6 +77,8 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source, Profile* profi
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
+  html_source->AddString("webRTCLearnMoreURL",
+      base::ASCIIToUTF16(kWebRTCLearnMoreURL));
 }
 
 void BraveAddLocalizedStrings(content::WebUIDataSource* html_source,