Add promotion id to iOS ClaimPromotion wrapper method

brave · May 10, 2020 · 435dd91 · 435dd91
1 parent 58b4231
commit 435dd91
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/vendor/brave-ios/Ledger/BATBraveLedger.h b/vendor/brave-ios/Ledger/BATBraveLedger.h
@@ -215,7 +215,8 @@ NS_SWIFT_NAME(BraveLedger)
 
 - (void)fetchPromotions:(nullable void (^)(NSArray<BATPromotion *> *grants))completion;
 
-- (void)claimPromotion:(NSString *)deviceCheckPublicKey
+- (void)claimPromotion:(NSString *)promotionId
+             publicKey:(NSString *)deviceCheckPublicKey
             completion:(void (^)(BATResult result, NSString * _Nonnull nonce))completion;
 
 - (void)attestPromotion:(NSString *)promotionId

diff --git a/vendor/brave-ios/Ledger/BATBraveLedger.mm b/vendor/brave-ios/Ledger/BATBraveLedger.mm
@@ -941,17 +941,16 @@ - (void)fetchPromotions:(nullable void (^)(NSArray<BATPromotion *> *grants))comp
   });
 }
 
-- (void)claimPromotion:(NSString *)deviceCheckPublicKey completion:(void (^)(BATResult result, NSString * _Nonnull nonce))completion
+- (void)claimPromotion:(NSString *)promotionId publicKey:(NSString *)deviceCheckPublicKey completion:(void (^)(BATResult result, NSString * _Nonnull nonce))completion
 {
   const auto payload = [NSDictionary dictionaryWithObject:deviceCheckPublicKey forKey:@"publicKey"];
   const auto jsonData = [NSJSONSerialization dataWithJSONObject:payload options:0 error:nil];
   if (!jsonData) {
     BLOG(ledger::LogLevel::LOG_ERROR) << "Missing JSON payload while attempting to claim promotion" << std::endl;
     return;
   }
-  // TODO we need to put promotion id in
   const auto jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
-  ledger->ClaimPromotion(jsonString.UTF8String, ^(const ledger::Result result, const std::string& json) {
+  ledger->ClaimPromotion(promotionId.UTF8String, jsonString.UTF8String, ^(const ledger::Result result, const std::string& json) {
     const auto jsonData = [[NSString stringWithUTF8String:json.c_str()] dataUsingEncoding:NSUTF8StringEncoding];
     NSDictionary *nonce = [NSJSONSerialization JSONObjectWithData:jsonData options:0 error:nil];
     dispatch_async(dispatch_get_main_queue(), ^{