-
Notifications
You must be signed in to change notification settings - Fork 879
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor patching based on review comments
- Move adding Open Link with Tor into InitMenu and remove AppendBraveLinkItems - Fix bug when removing IDC_CONTENT_CONTEXT_TRANSLATE since it is not always existed - Define BRAVE_RENDER_VIEW_CONTEXT_MENU_H_ and BRAVE_TRANSLATE_BUBBLE_VIEW_H_ to be extensible in the header
- Loading branch information
Showing
6 changed files
with
41 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
patches/chrome-browser-renderer_context_menu-render_view_context_menu.cc.patch
This file was deleted.
Oops, something went wrong.
11 changes: 4 additions & 7 deletions
11
patches/chrome-browser-renderer_context_menu-render_view_context_menu.h.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,12 @@ | ||
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.h b/chrome/browser/renderer_context_menu/render_view_context_menu.h | ||
index 824741727052dfd87f8f65df8bbb5adf4a9f1e2e..04cef1566ff4067487211486ad0e2133e8eab585 100644 | ||
index 824741727052dfd87f8f65df8bbb5adf4a9f1e2e..3caba335f84e5126c5912451b5dbcc807b21f62a 100644 | ||
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.h | ||
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.h | ||
@@ -114,7 +114,10 @@ class RenderViewContextMenu : public RenderViewContextMenuBase { | ||
@@ -113,6 +113,7 @@ class RenderViewContextMenu : public RenderViewContextMenuBase { | ||
// Returns true if keyboard lock is active and requires the user to press and | ||
// hold escape to exit exclusive access mode. | ||
bool IsPressAndHoldEscRequiredToExitFullscreen() const; | ||
+ BRAVE_RENDER_VIEW_CONTEXT_MENU_H_ | ||
|
||
+ virtual void AppendBraveLinkItems(); | ||
+ | ||
private: | ||
+ friend class BraveRenderViewContextMenu; | ||
friend class RenderViewContextMenuTest; | ||
friend class TestRenderViewContextMenu; | ||
friend class FormatUrlForClipboardTest; |
16 changes: 8 additions & 8 deletions
16
patches/chrome-browser-ui-views-translate-translate_bubble_view.h.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h | ||
index 0eba3d7441cb352e81faea58548c87b40489f5a2..c5514bf7018a89c328bd11cfaaeecea7f9103d5b 100644 | ||
index 0eba3d7441cb352e81faea58548c87b40489f5a2..9775f33cf6df16c01f837cf6d0defa41f20f3fc5 100644 | ||
--- a/chrome/browser/ui/views/translate/translate_bubble_view.h | ||
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h | ||
@@ -143,6 +143,7 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView, | ||
COMBOBOX_ID_TARGET_LANGUAGE, | ||
}; | ||
@@ -117,6 +117,7 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView, | ||
|
||
+ friend class BraveTranslateBubbleView; | ||
friend class TranslateBubbleViewTest; | ||
friend void ::translate::test_utils::PressTranslate(::Browser*); | ||
friend void ::translate::test_utils::PressRevert(::Browser*); | ||
// Returns the current view state. | ||
TranslateBubbleModel::ViewState GetViewState() const; | ||
+ BRAVE_TRANSLATE_BUBBLE_VIEW_H_ | ||
|
||
protected: | ||
// LocationBarBubbleDelegateView: |