Small bug fix for last grant deletion

Adding test to reflect change
brave · Feb 11, 2019 · a2ef113 · a2ef113
1 parent ff40ce8
commit a2ef113
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 2 deletions.
diff --git a/...rave_rewards/resources/extension/brave_rewards/background/reducers/grant_panel_reducer.ts b/...rave_rewards/resources/extension/brave_rewards/background/reducers/grant_panel_reducer.ts
@@ -157,7 +157,7 @@ export const grantPanelReducer = (state: RewardsExtension.State | undefined, act
           })
 
           if (grantIndex > -1) {
-            grants = state.grants.splice(1, grantIndex)
+            grants = state.grants.splice(grantIndex, 1)
             currentGrant = undefined
           }
 

diff --git a/components/brave_rewards/resources/ui/reducers/grant_reducer.ts b/components/brave_rewards/resources/ui/reducers/grant_reducer.ts
@@ -153,7 +153,7 @@ const grantReducer: Reducer<Rewards.State | undefined> = (state: Rewards.State,
           })
 
           if (grantIndex > -1) {
-            state.grants.splice(1, grantIndex)
+            state.grants.splice(grantIndex, 1)
             currentGrant = undefined
           }
 

diff --git a/components/test/brave_rewards/ui/reducers/grant_reducer_test.ts b/components/test/brave_rewards/ui/reducers/grant_reducer_test.ts
@@ -325,6 +325,42 @@ describe('Grant Reducer', () => {
         }
       ]
 
+      expect(assertion).toEqual({
+        rewardsData: expectedState
+      })
+    })
+    it('deletes last grant', () => {
+      const initialState = {
+        ...defaultState
+      }
+      initialState.grants = [
+        {
+          promotionId: 'test-promotion-id-2',
+          expiryTime: 0,
+          probi: '',
+          type: 'ads',
+          captcha: 'data:image/jpeg;base64,XXX',
+          hint: 'blue'
+        }
+      ]
+      initialState.currentGrant = {
+        promotionId: 'test-promotion-id-2',
+        expiryTime: 0,
+        probi: '',
+        type: 'ads'
+      }
+
+      const assertion = reducers({
+        rewardsData: initialState
+      }, {
+        type: types.ON_GRANT_DELETE,
+        payload: {}
+      })
+
+      const expectedState: Rewards.State = { ...defaultState }
+      expectedState.currentGrant = undefined
+      expectedState.grants = []
+
       expect(assertion).toEqual({
         rewardsData: expectedState
       })