Skip to content

Commit

Permalink
Add create_dist for Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
bbondy committed Jan 20, 2018
1 parent 504cb0e commit bec4a13
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 3 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ node_modules/
*.sln
debug.log
npm-debug.log
*~
1 change: 0 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ group("brave") {
}

repack("packed_extra_resources") {
visibility = [ "./*" ]
sources = [
"$root_gen_dir/components/brave_components_resources.pak",
"$target_gen_dir/browser/resources/brave_extension.pak",
Expand Down
17 changes: 15 additions & 2 deletions patches/chrome-installer-mini_installer-BUILD.gn.patch
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index cc3782f4a91da503a743d38740210f8f8a973e8d..b82f855146f80e8ffa4ad3a3ba438dcc5a3c1623 100644
index cc3782f4a91da503a743d38740210f8f8a973e8d..e5da0757587fca503577892afd84ed4eaf35787e 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -130,7 +130,7 @@ template("generate_mini_installer") {
@@ -130,11 +130,12 @@ template("generate_mini_installer") {

inputs = [
"$chrome_dll_file",
Expand All @@ -11,3 +11,16 @@ index cc3782f4a91da503a743d38740210f8f8a973e8d..b82f855146f80e8ffa4ad3a3ba438dcc
"$root_out_dir/locales/en-US.pak",
"$root_out_dir/setup.exe",
"$root_out_dir/v8_context_snapshot.bin",
release_file,
+ "$root_out_dir/brave_resources.pak",
]

outputs = [
@@ -179,6 +180,7 @@ template("generate_mini_installer") {
"//third_party/icu:icudata",
"//tools/v8_context_snapshot",
chrome_dll_target,
+ "//brave:packed_extra_resources",
]

if (enable_hidpi) {
12 changes: 12 additions & 0 deletions patches/chrome-installer-mini_installer-chrome.release.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/chrome/installer/mini_installer/chrome.release b/chrome/installer/mini_installer/chrome.release
index fe8c8c00e57dcf1cb154448d05eba6ac209ee3ed..5b5f05cbdf866ace7572066709e426b40e2e60ff 100644
--- a/chrome/installer/mini_installer/chrome.release
+++ b/chrome/installer/mini_installer/chrome.release
@@ -18,6 +18,7 @@ chrome.exe: %(ChromeDir)s\
# Chrome version dir entries, sorted alphabetically.
#
chrome.dll: %(VersionDir)s\
+brave_resources.pak: %(VersionDir)s\
chrome_100_percent.pak: %(VersionDir)s\
chrome_child.dll: %(VersionDir)s\
chrome_elf.dll: %(VersionDir)s\
12 changes: 12 additions & 0 deletions patches/chrome-installer-util-BUILD.gn.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/chrome/installer/util/BUILD.gn b/chrome/installer/util/BUILD.gn
index 2cf4027737f73cff9fcd061ed46b6b92f3587e84..ed50f727682cc228ddbed518a3271999fcda0403 100644
--- a/chrome/installer/util/BUILD.gn
+++ b/chrome/installer/util/BUILD.gn
@@ -239,6 +239,7 @@ action("generate_strings") {

inputs = [
grdfile,
+ "//chrome/app/brave_strings.grd",
]

outputs = [

0 comments on commit bec4a13

Please sign in to comment.