Skip to content

Commit

Permalink
Brave Today promoted content label is localized
Browse files Browse the repository at this point in the history
  • Loading branch information
petemill committed Jan 21, 2021
1 parent 0343ea4 commit c8827e9
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions browser/ui/webui/brave_webui_source.cc
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ void CustomizeWebUIHTMLSource(const std::string &name,
{ "braveTodaySourcesTitle", IDS_BRAVE_TODAY_SOURCES_TITLE},
{ "braveTodayDisableSourceCommand",
IDS_BRAVE_TODAY_DISABLE_SOURCE_COMMAND},
{ "promoted", IDS_BRAVE_TODAY_PROMOTED },

{ "addWidget", IDS_BRAVE_NEW_TAB_WIDGET_ADD },
{ "hideWidget", IDS_BRAVE_NEW_TAB_WIDGET_HIDE },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@
// you can obtain one at http://mozilla.org/MPL/2.0/.

import * as React from 'react'
import VisibilityTimer from '../../../../../helpers/visibilityTimer'
import { getLocale } from '../../../../../../common/locale'
import * as Card from '../../cardSizes'
import CardImage from '../CardImage'
import PublisherMeta from '../PublisherMeta'
import useScrollIntoView from '../../useScrollIntoView'
import useReadArticleClickHandler from '../../useReadArticleClickHandler'
import { OnReadFeedItem, OnSetPublisherPref } from '../../'
import VisibilityTimer from '../../../../../helpers/visibilityTimer'
import CardImage from '../CardImage'
import PublisherMeta from '../PublisherMeta'
// TODO(petemill): Large and Medium article should be combined to 1 component.

interface Props {
Expand Down Expand Up @@ -116,7 +117,7 @@ const LargeArticle = React.forwardRef<HTMLElement, ArticleProps>(function (props
/>
</svg>
</Card.PromotedIcon>
Promoted
{getLocale('promoted')}
</Card.PromotedLabel>
}
</Card.Source>
Expand Down
3 changes: 3 additions & 0 deletions components/resources/brave_components_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@
<message name="IDS_BRAVE_TODAY_DISABLE_SOURCE_COMMAND" desc="Command text to disable a specific publisher from showing in the feed">
Disable content from <ph name="PUBLISHER_NAME">$1<ex>The New York Times</ex></ph>
</message>
<message name="IDS_BRAVE_TODAY_PROMOTED" desc="Label for promoted content">
Promoted
</message>

<message name="IDS_BRAVE_NEW_TAB_STATS_TAB" desc="Brave Stats title">Brave Stats</message>
<message name="IDS_BRAVE_NEW_TAB_CLOCK_TAB" desc="Clock title">Clock</message>
Expand Down

0 comments on commit c8827e9

Please sign in to comment.