Remove flickering for CSS filters

brave · Aug 21, 2018 · d192d23 · d192d23
1 parent 63363a7
commit d192d23
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/app/background/api/cosmeticFilterAPI.ts b/app/background/api/cosmeticFilterAPI.ts
@@ -24,7 +24,8 @@ export const applySiteFilters = (hostname: string) => {
       storeData.cosmeticFilterList[hostname].map((rule: string) => {
         console.log('applying rule', rule)
         chrome.tabs.insertCSS({
-          code: `${rule} {display: none;}`
+          code: `${rule} {display: none;}`,
+          runAt: 'document_start'
         })
       })
     }

diff --git a/test/app/background/api/cosmeticFilterAPITest.ts b/test/app/background/api/cosmeticFilterAPITest.ts
@@ -184,7 +184,8 @@ describe('cosmeticFilterTestSuite', () => {
       })
       cosmeticFilterAPI.applySiteFilters('brave.com')
       assert.deepEqual(this.insertCSSStub.getCall(0).args[0], {
-        code: `${filter} {display: none;}`
+        code: `${filter} {display: none;}`,
+        runAt: 'document_start'
       })
     })
     it('applies multiple filters correctly', function () {
@@ -195,10 +196,12 @@ describe('cosmeticFilterTestSuite', () => {
       })
       cosmeticFilterAPI.applySiteFilters('brave.com')
       assert.deepEqual(this.insertCSSStub.getCall(0).args[0], {
-        code: `${filter} {display: none;}`
+        code: `${filter} {display: none;}`,
+        runAt: 'document_start'
       })
       assert.deepEqual(this.insertCSSStub.getCall(1).args[0], {
-        code: `${filter2} {display: none;}`
+        code: `${filter2} {display: none;}`,
+        runAt: 'document_start'
       })
 
     })