Skip to content

Commit

Permalink
Fixed Windows build error caused by "Implement additional ad event co…
Browse files Browse the repository at this point in the history
…nfirmations”

fixes brave/brave-browser#3679
  • Loading branch information
tmancey authored Mar 13, 2019
1 parent f23ccda commit dd5aff4
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 21 deletions.
4 changes: 2 additions & 2 deletions vendor/bat-native-ads/include/bat/ads/ads_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@

namespace ads {

enum ADS_EXPORT LogLevel {
enum LogLevel {
LOG_ERROR = 1,
LOG_WARNING,
LOG_INFO
};

enum ADS_EXPORT URLRequestMethod {
enum URLRequestMethod {
GET = 0,
PUT = 1,
POST = 2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@
#ifndef BAT_ADS_CLIENT_INFO_PLATFORM_TYPE_H_
#define BAT_ADS_CLIENT_INFO_PLATFORM_TYPE_H_

#include "bat/ads/export.h"

namespace ads {

enum ADS_EXPORT ClientInfoPlatformType {
enum ClientInfoPlatformType {
UNKNOWN,
WINDOWS,
MACOS,
Expand Down
6 changes: 1 addition & 5 deletions vendor/bat-native-ads/include/bat/ads/confirmation_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,14 @@
#ifndef BAT_ADS_CONFIRMATION_TYPE_H_
#define BAT_ADS_CONFIRMATION_TYPE_H_

#include <string>

#include "bat/ads/export.h"

namespace ads {

static char kConfirmationTypeClick[] = "click";
static char kConfirmationTypeDismiss[] = "dismiss";
static char kConfirmationTypeView[] = "view";
static char kConfirmationTypeLanded[] = "landed";

enum class ADS_EXPORT ConfirmationType {
enum class ConfirmationType {
UNKNOWN,
CLICK,
DISMISS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@
#ifndef BAT_ADS_NOTIFICATION_RESULT_TYPE_H_
#define BAT_ADS_NOTIFICATION_RESULT_TYPE_H_

#include "bat/ads/export.h"

namespace ads {

enum class ADS_EXPORT NotificationResultInfoResultType {
enum class NotificationResultInfoResultType {
CLICKED,
DISMISSED,
TIMEOUT
Expand Down
4 changes: 1 addition & 3 deletions vendor/bat-native-ads/include/bat/ads/result.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@
#ifndef BAT_ADS_RESULT_H_
#define BAT_ADS_RESULT_H_

#include "bat/ads/export.h"

namespace ads {

enum ADS_EXPORT Result {
enum Result {
SUCCESS,
FAILED
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,14 @@
#ifndef BAT_CONFIRMATIONS_CONFIRMATION_TYPE_H_
#define BAT_CONFIRMATIONS_CONFIRMATION_TYPE_H_

#include <string>

#include "bat/confirmations/export.h"

namespace confirmations {

static char kConfirmationTypeClick[] = "click";
static char kConfirmationTypeDismiss[] = "dismiss";
static char kConfirmationTypeView[] = "view";
static char kConfirmationTypeLanded[] = "landed";

enum class CONFIRMATIONS_EXPORT ConfirmationType {
enum class ConfirmationType {
UNKNOWN,
CLICK,
DISMISS,
Expand Down

0 comments on commit dd5aff4

Please sign in to comment.