Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the UI value for emptyWallet #1004

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Set the UI value for emptyWallet #1004

merged 1 commit into from
Dec 3, 2018

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#2260

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

See #992

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton self-assigned this Dec 2, 2018
@bsclifton bsclifton requested a review from garrettr December 2, 2018 22:14
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsclifton bsclifton merged commit 471b8f1 into master Dec 3, 2018
@bsclifton bsclifton deleted the bsc-fix-2260 branch December 3, 2018 16:37
bsclifton added a commit that referenced this pull request Dec 3, 2018
Set the UI value for emptyWallet
bsclifton added a commit that referenced this pull request Dec 3, 2018
Set the UI value for emptyWallet
bsclifton added a commit that referenced this pull request Dec 3, 2018
Set the UI value for emptyWallet
@bsclifton
Copy link
Member Author

master 471b8f1
0.59.x 67a642c
0.58.x ff098ad
0.57.x 6e6a864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sadly, no tokens yet" after importing wallet with non-zero balance
3 participants