Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitFlyer onboarding asset #10045

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Sep 10, 2021

Resolves brave/brave-browser#18001

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Clean profile
  • Start brave with --rewards=countryid=19024 flag, to start with bitFlyer-appropriate countryid
  • Enable Rewards
  • Verify that new bitFlyer image appears at end of onboarding flow
  • Verify that clicking new bitFlyer image opens a new page to https://twitter.com/bravesoftwarejp

@emerick emerick requested a review from a team as a code owner September 10, 2021 16:03
@emerick emerick self-assigned this Sep 10, 2021
@emerick emerick merged commit e7df9eb into master Sep 10, 2021
@emerick emerick deleted the rewards-update-bitflyer-onboarding-asset branch September 10, 2021 19:15
@emerick emerick added this to the 1.31.x - Nightly milestone Sep 10, 2021
brave-builds pushed a commit that referenced this pull request Sep 10, 2021
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.31.37 Chromium: 93.0.4577.63 (Official Build) nightly (x86_64)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. Clean profile
  2. Set OS region to Japan
  3. Enabled Rewards
  4. Verified that the new bitFlyer image appears at end of onboarding flow
  5. Verified that clicking new bitFlyer image opened a new page to https://twitter.com/bravesoftwarejp
example example example
Screen Shot 2021-09-13 at 15 31 45 Screen Shot 2021-09-13 at 15 31 59 Screen Shot 2021-09-13 at 15 35 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bitFlyer promo image in onboarding flow (Sept 2021)
4 participants