Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar icon 1x revisions #1005

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Toolbar icon 1x revisions #1005

merged 1 commit into from
Dec 6, 2018

Conversation

rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Dec 3, 2018

Fixes brave/brave-browser#2327

Updated settings, home, stop, bookmark, back, forward and reload icons in only the non retina (16px) format by a 1/2 a pixel on the strokes.

beforeaftericons

Test plan (added by @petemill )

  • Icons are changed at 1x physical:virtual pixel resolutions
  • Icons are not changed at > 1x

- updated settings, home, stop, bookmark, back, forward and reload icons in only the non retina format by a 1/2 a pixel on the strokes.
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I can see the thinner strokes @rossmoody

@petemill petemill merged commit 7f2844f into master Dec 6, 2018
@petemill petemill deleted the icon-thin branch December 6, 2018 00:19
petemill added a commit that referenced this pull request Dec 6, 2018
Toolbar icon 1x revisions
@petemill
Copy link
Member

petemill commented Dec 6, 2018

master (0.60) 7f2844f
0.59.x 245b0a9

@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants