Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables kCopyLinkToText feature. #10085

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#17994

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested review from pes10k and yrliou September 14, 2021 19:37
@mkarolin mkarolin self-assigned this Sep 14, 2021
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin force-pushed the maxk-disable-copy-link-to-text branch from 08b102a to 296325a Compare September 14, 2021 20:35
@mkarolin mkarolin force-pushed the maxk-disable-copy-link-to-text branch from 296325a to 0f2e0eb Compare September 14, 2021 22:21
@mkarolin mkarolin merged commit 41bd847 into master Sep 15, 2021
@mkarolin mkarolin deleted the maxk-disable-copy-link-to-text branch September 15, 2021 13:41
@mkarolin mkarolin added this to the 1.31.x - Nightly milestone Sep 15, 2021
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.31.47 Chromium: 94.0.4606.50 (Official Build) nightly (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. clean profile
  2. launched Brave
  3. opened wikipedia.org/wiki/Earth
  4. selected text on the page and invoked the context menu

Confirmed there is no Copy link to highlight menu item available.

Screen Shot 2021-09-16 at 2 36 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave://flags/#copy-link-to-text should be disabled by default
3 participants