Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16005
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
GET /v1/issuers
creativeType
(i.e.ad_notification
,new_tab_page_ad
,inline_content_ad
orpromoted_content_ad
) is not included in the payload when tokens are cashed-outGET /v1/issuers/
endpointGET /v1/issuers/
endpoint on browser launchping
inGET /v1/issuers/
response)unblinded_payment_tokens
node inconfirmations.json
is migrated to includead_type
(empty string),confirmation_type
(empty string) andtransaction_id
(random v4 UUID)confirmations.json
unblinded_payment_tokens
node inconfirmations.json
hasad_type
,confirmation_type
andtransaction_id
for new entriesGET /v9/catalog
endpointNOTE:
Failed to get issuers
will be shown after upgrading because theissuers
node will only be created after successfully downloading issuers fromGET /v1/issuers/
for the first time. See the spec for more detail