-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt user to close Chrome before importing from a Chrome profile #101
Conversation
52637cf
to
9d7060a
Compare
9d7060a
to
a44a433
Compare
void ChromeProfileLock::Unlock() { | ||
if (!HasAcquired()) | ||
return; | ||
process_singleton_.Cleanup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should set lock_acquired_
to false here and notice once this singleton has been cleanup, it can't be used again. Just in case we will use Unlock
else where other than destructor in the future and also have a correct behavior in unittest.
addressed in a44a433
a44a433
to
d6890a3
Compare
d6890a3
to
9f3644d
Compare
9f3644d
to
3e68ed7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
User changing default monthly value is now indicated in state
Use default config so ninja is in PATH
Use default config so ninja is in PATH
Use default config so ninja is in PATH
The UX and implementation are based on how Chrome's Firefox importer prompts the user to close Firefox before importing from a Firefox profile. ChromeProfileLock provides the same interface as FirefoxProfileLock, and the implementation is simpler because we are able to reuse Chromium's ProcessSingleton to check if Chrome is running at the time of import.
Resolves brave/brave-browser#103.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan
Manual testing
yarn start
Cross-platform testing
I have verified that this PR builds and passes the manual tests described above on macOS, Windows, and Linux.
Reviewer Checklist: