-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support separate lists for origin and target languages #10338
Conversation
e22a366
to
2117f2e
Compare
57db559
to
353a5ca
Compare
components/translate/core/browser/brave_translate_language_filter.cc
Outdated
Show resolved
Hide resolved
browser/net/brave_translate_redirect_network_delegate_helper_unittest.cc
Outdated
Show resolved
Hide resolved
69c1471
to
e915125
Compare
chromium_src/components/translate/core/browser/translate_manager.h
Outdated
Show resolved
Hide resolved
chromium_src/components/translate/core/browser/translate_manager.cc
Outdated
Show resolved
Hide resolved
chromium_src/components/translate/core/browser/translate_manager.cc
Outdated
Show resolved
Hide resolved
components/translate/core/browser/brave_translate_language_filter.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/translate/translate_bubble_model_impl.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/translate/translate_bubble_model_impl.h
Outdated
Show resolved
Hide resolved
chromium_src/chrome/browser/ui/translate/translate_bubble_model_impl.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as discussed language support looks good
56a8522
to
3461bbd
Compare
} | ||
} | ||
|
||
TranslateBubbleModelImpl::~TranslateBubbleModelImpl() = default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we accomplish the same thing here by subclass/override TranslateUIDelegate
in TranslateBubbleView? Seems like that would be simpler and cleaner, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea @bridiver, thanks.
Would you mind if I did it in the next PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up is fine
Resolves brave/brave-browser#18592
Two separate languages lists (one for source and once for target) are implemented to supported Brave backend restrictions.
We agreed to disable the buildflag again
enable_brave_translate_go
before merging so nothing will be changed before enabling it again.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: