-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable internal translate engine #10453
Conversation
16c79cd
to
5f10a7c
Compare
@fmarier could you please take a look? |
Thanks @atuchin-m . I looked at the hostname replacement code and that looked fine to me. |
Thanks @fmarier. |
chromium_src/components/translate/core/browser/translate_script.cc
Outdated
Show resolved
Hide resolved
chromium_src/components/translate/content/renderer/isolated_world_util.cc
Show resolved
Hide resolved
chromium_src/components/translate/content/renderer/isolated_world_util.cc
Show resolved
Hide resolved
1c72220
to
4c8281d
Compare
@simonhong @yrliou @iefremov PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
views: ++ (not familiar with other core translate part)
38ce417
to
2c6a5e8
Compare
Resolves brave/brave-browser#18593
Core:
UI:
Network and the translate script:
*.brave.com
translate-relay.brave.com
using chromium switches.Bowser tests for redirection will be added if anything is ok.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: