Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't resize tooltip popup after moving it #10626

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 20, 2021

Resolves brave/brave-browser#18891

Fix is based on similar fix for brave/brave-browser#16241

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Schedule an adaptive captcha
  • Wait for tooltip to appear on Windows
  • Drag tooltip window and ensure it doesn't resize
  • Open display settings and change your display's scale factor (e.g., make it 150%)
  • Drag tooltip window and ensure it doesn't resize
  • Don't forget to reset your scale factor :-)

@emerick emerick self-assigned this Oct 20, 2021
@emerick emerick merged commit e3b855b into master Oct 21, 2021
@emerick emerick deleted the rewards-dragging-captcha-tooltip-resizes-it branch October 21, 2021 15:19
@emerick emerick added this to the 1.33.x - Nightly milestone Oct 21, 2021
brave-builds pushed a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging Rewards aCAPTCHA prompt grows to fill up screen
2 participants