Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads will not be served for campaign with more than one state geotarget #10735

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 27, 2021

Resolves brave/brave-browser#19050

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#19050

@tmancey tmancey self-assigned this Oct 27, 2021
@tmancey tmancey force-pushed the issues/19050 branch 7 times, most recently from 3cc32b6 to c68c24a Compare October 28, 2021 00:39
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btlechowski
Copy link

Good to uplift. QA decided to make basic test on the PR and test more on 1.31.x RC.

Brave 1.33.41 Chromium: 95.0.4638.54 (Official Build) nightly (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-browser#19050

Ad 1 on US-OR

[7597:7597:1028/213854.477673:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[7597:7597:1028/213854.478570:VERBOSE1:eligible_ad_notifications_v1.cc(140)] Get eligible ads for untargeted segment
[7597:7597:1028/213854.479930:VERBOSE2:ad_priority.h(32)] 2 ads with a priority of 1 in bucket 1
[7597:7597:1028/213854.480096:VERBOSE1:ad_notification_serving.cc(144)] Found 2 eligible ads
[7597:7597:1028/213854.480142:VERBOSE1:ad_notification_serving.cc(263)] Serving ad notification:
  uuid: 187d3ff7-1242-4247-89b6-0e8949c517b1
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad AAA
  body: Ad AAA
  targetUrl: https://youtube.com

Ad 2 on US-OR

[8049:8049:1028/224334.943555:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[8049:8049:1028/224334.944780:VERBOSE1:eligible_ad_notifications_v1.cc(140)] Get eligible ads for untargeted segment
[8049:8049:1028/224334.946769:VERBOSE1:seen_advertisers.h(30)] All ad_notification advertisers have been shown, so round robin
[8049:8049:1028/224334.946909:VERBOSE1:client.cc(500)] Resetting seen ad_notification advertisers
[8049:8049:1028/224334.947073:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[8049:8049:1028/224334.947212:VERBOSE1:ad_notification_serving.cc(144)] Found 1 eligible ads
[8049:8049:1028/224334.947232:VERBOSE1:ad_notification_serving.cc(263)] Serving ad notification:
  uuid: f614adc9-d372-466e-be5f-7cc4e9d6fec2
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad BBB
  body: Ad BBB
  targetUrl: https://youtube.com

Ad 3 on US-CA

[8412:8412:1028/234606.574290:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[8412:8412:1028/234606.575412:VERBOSE1:eligible_ad_notifications_v1.cc(140)] Get eligible ads for untargeted segment
[8412:8412:1028/234606.586099:VERBOSE1:seen_advertisers.h(30)] All ad_notification advertisers have been shown, so round robin
[8412:8412:1028/234606.586657:VERBOSE1:client.cc(500)] Resetting seen ad_notification advertisers
[8412:8412:1028/234606.586948:VERBOSE1:seen_ads.h(30)] All ad_notification ads have been shown, so round robin
[8412:8412:1028/234606.587336:VERBOSE1:client.cc(464)] Resetting seen ad_notifications
[8412:8412:1028/234606.589293:VERBOSE2:ad_priority.h(32)] 2 ads with a priority of 1 in bucket 1
[8412:8412:1028/234606.589809:VERBOSE1:ad_notification_serving.cc(144)] Found 2 eligible ads
[8412:8412:1028/234606.589870:VERBOSE1:ad_notification_serving.cc(263)] Serving ad notification:
  uuid: b19c74c9-ee3d-448f-931b-8221393890fa
  creativeInstanceId: a0369601-b46f-46aa-93e1-2c9bafda3c35
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad AAA
  body: Ad AAA
  targetUrl: https://youtube.com

Ad 4 on US-CA

[8791:8791:1029/005149.677013:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[8791:8791:1029/005149.678535:VERBOSE1:eligible_ad_notifications_v1.cc(140)] Get eligible ads for untargeted segment
[8791:8791:1029/005149.682240:VERBOSE1:seen_advertisers.h(30)] All ad_notification advertisers have been shown, so round robin
[8791:8791:1029/005149.682490:VERBOSE1:client.cc(500)] Resetting seen ad_notification advertisers
[8791:8791:1029/005149.683316:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[8791:8791:1029/005149.684146:VERBOSE1:ad_notification_serving.cc(144)] Found 1 eligible ads
[8791:8791:1029/005149.686711:VERBOSE1:ad_notification_serving.cc(263)] Serving ad notification:
  uuid: a8bcf0fa-a391-4af2-86ad-3cd271284c9d
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad BBB
  body: Ad BBB
  targetUrl: https://youtube.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads will not be served for campaign with more than one state geotarget
5 participants