-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ads will not be served for campaign with more than one state geotarget #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/19050
branch
7 times, most recently
from
October 28, 2021 00:39
3cc32b6
to
c68c24a
Compare
aseren
reviewed
Oct 28, 2021
...-native-ads/src/bat/ads/internal/database/tables/creative_new_tab_page_ads_database_table.cc
Show resolved
Hide resolved
aseren
reviewed
Oct 28, 2021
...ive-ads/src/bat/ads/internal/database/tables/creative_promoted_content_ads_database_table.cc
Show resolved
Hide resolved
aseren
approved these changes
Oct 28, 2021
moritzhaller
approved these changes
Oct 28, 2021
emerick
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Oct 28, 2021
Good to uplift. QA decided to make basic test on the PR and test more on 1.31.x RC.
Verified test plan from brave/brave-browser#19050 Ad 1 on US-OR
Ad 2 on US-OR
Ad 3 on US-CA
Ad 4 on US-CA
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#19050
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#19050