Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial work on bitFlyer support on Android #10934

Closed
wants to merge 2 commits into from

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 8, 2021

Resolves brave/brave-browser#18439

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Nov 8, 2021
@emerick emerick force-pushed the emerick-rewards-bitflyer-android-integration branch 7 times, most recently from dd9dfb6 to 4b82c8c Compare November 10, 2021 12:02
@emerick emerick force-pushed the emerick-rewards-bitflyer-android-integration branch 9 times, most recently from 83a3fdb to 696b246 Compare November 18, 2021 12:03
@emerick emerick force-pushed the emerick-rewards-bitflyer-android-integration branch 6 times, most recently from d323166 to 7d232fc Compare November 24, 2021 21:14
@emerick emerick force-pushed the emerick-rewards-bitflyer-android-integration branch 6 times, most recently from 324030f to 76f41d1 Compare December 3, 2021 12:21
@emerick emerick force-pushed the emerick-rewards-bitflyer-android-integration branch 4 times, most recently from 465f634 to 28e683d Compare December 7, 2021 12:09
@emerick emerick force-pushed the emerick-rewards-bitflyer-android-integration branch from 28e683d to 907e9a6 Compare December 8, 2021 12:21
@emerick emerick closed this Dec 8, 2021
@emerick emerick deleted the emerick-rewards-bitflyer-android-integration branch December 8, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Implement bitFlyer Rewards user wallets
1 participant