Migrate crypto widgets visibility in NTP

browser/brave_profile_prefs.cc

@@ -317,6 +317,7 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(kNewTabPageShowBraveTalk, false);
   registry->RegisterBooleanPref(kNewTabPageShowGemini, true);
   registry->RegisterBooleanPref(kNewTabPageHideAllWidgets, false);
+  registry->RegisterBooleanPref(kNewTabPageWidgetVisibilityMigrated, false);
 
   registry->RegisterIntegerPref(
       kNewTabPageShowsOptions,

browser/ui/webui/new_tab_page/brave_new_tab_message_handler.cc

@@ -110,6 +110,8 @@ base::DictionaryValue GetPreferencesDictionary(PrefService* prefs) {
   pref_data.SetBoolean("showBraveTalk",
                        prefs->GetBoolean(kNewTabPageShowBraveTalk));
   pref_data.SetBoolean("showGemini", prefs->GetBoolean(kNewTabPageShowGemini));
+  pref_data.SetBoolean("widgetVisibilityMigrated",
+                       prefs->GetBoolean(kNewTabPageWidgetVisibilityMigrated));
 #if BUILDFLAG(CRYPTO_DOT_COM_ENABLED)
   pref_data.SetBoolean(
       "showCryptoDotCom",
@@ -501,6 +503,10 @@ void BraveNewTabMessageHandler::HandleSaveNewTabPagePref(
     settingsKey = kNewTabPageShowBraveTalk;
   } else if (settingsKeyInput == "showGemini") {
     settingsKey = kNewTabPageShowGemini;
+  } else if (settingsKeyInput == "saveWidgetVisibilityMigrated") {
+    // This prefs is set to true once.
+    DCHECK(settingsValueBool);
+    settingsKey = kNewTabPageWidgetVisibilityMigrated;
 #if BUILDFLAG(CRYPTO_DOT_COM_ENABLED)
   } else if (settingsKeyInput == "showCryptoDotCom") {
     settingsKey = kCryptoDotComNewTabPageShowCryptoDotCom;

common/pref_names.cc

@@ -64,6 +64,8 @@ const char kNewTabPageShowGemini[] = "brave.new_tab_page.show_gemini";
 const char kNewTabPageShowBraveTalk[] = "brave.new_tab_page.show_together";
 const char kNewTabPageHideAllWidgets[] = "brave.new_tab_page.hide_all_widgets";
 const char kNewTabPageShowsOptions[] = "brave.new_tab_page.shows_options";
+const char kNewTabPageWidgetVisibilityMigrated[] =
+    "brave.new_tab_page.widget_visibility_migrated";
 const char kBraveTodayIntroDismissed[] = "brave.today.intro_dismissed";
 const char kBinanceAccessToken[] = "brave.binance.access_token";
 const char kBinanceRefreshToken[] = "brave.binance.refresh_token";

common/pref_names.h

@@ -56,6 +56,7 @@ extern const char kNewTabPageShowGemini[];
 extern const char kNewTabPageShowBraveTalk[];
 extern const char kNewTabPageHideAllWidgets[];
 extern const char kNewTabPageShowsOptions[];
+extern const char kNewTabPageWidgetVisibilityMigrated[];
 extern const char kBraveTodayIntroDismissed[];
 extern const char kAlwaysShowBookmarkBarOnNTP[];
 extern const char kAutocompleteEnabled[];

components/brave_new_tab_ui/actions/new_tab_actions.ts

@@ -46,6 +46,9 @@ export const clockWidgetUpdated = (showClockWidget: boolean,
 export const setInitialData = (initialData: InitialData) =>
   action(types.NEW_TAB_SET_INITIAL_DATA, initialData)
 
+export const setWidgetVisibilityMigrationData = (ftxAuthed: boolean) =>
+  action(types.NEW_TAB_SET_WIDGET_VISIBILITY_MIGRATION_DATA, ftxAuthed)
+
 export const setMostVisitedSettings = (showTopSites: boolean, customLinksEnabled: boolean) =>
   action(types.SET_MOST_VISITED_SITES, { showTopSites, customLinksEnabled })
 

components/brave_new_tab_ui/api/preferences.ts

@@ -22,6 +22,10 @@ function sendSavePref (key: string, value: any) {
   chrome.send('saveNewTabPagePref', [key, value])
 }
 
+export function saveWidgetVisibilityMigrated (): void {
+  sendSavePref('saveWidgetVisibilityMigrated', true)
+}
+
 export function saveShowBackgroundImage (value: boolean): void {
   sendSavePref('showBackgroundImage', value)
 }

components/brave_new_tab_ui/apiEventsToStore.ts

@@ -48,6 +48,14 @@ export function wireApiEventsToStore () {
       rewardsInitData()
     }
     getActions().setInitialData(initialData)
+    if (!initialData.preferences.widgetVisibilityMigrated) {
+      // Other widget's auth state can be fetched from local storage.
+      // But, need to fetch ftx auth state to migrate.
+      // Start migration when ftx auth state is ready.
+      chrome.ftx.getAccountBalances((balances, authInvalid) => {
+       getActions().setWidgetVisibilityMigrationData(!authInvalid)
+      })
+    }
     // Listen for API changes and dispatch to store
     topSitesAPI.addMostVistedInfoChangedListener(onMostVisitedInfoChanged)
     topSitesAPI.updateMostVisitedInfo()

components/brave_new_tab_ui/constants/new_tab_types.ts

@@ -19,6 +19,7 @@ export const enum types {
   NEW_TAB_PREFERENCES_UPDATED = '@@newtab/NEW_TAB_PREFERENCES_UPDATED',
   NEW_TAB_DISMISS_BRANDED_WALLPAPER_NOTIFICATION = '@@newtab/NEW_TAB_DISMISS_BRANDED_WALLPAPER_NOTIFICATION',
   NEW_TAB_SET_INITIAL_DATA = '@@newtab/NEW_TAB_SET_INITIAL_DATA',
+  NEW_TAB_SET_WIDGET_VISIBILITY_MIGRATION_DATA = '@@newtab/NEW_TAB_SET_WIDGET_VISIBILITY_MIGRATION_DATA',
   SET_MOST_VISITED_SITES = '@@newtab/SET_MOST_VISITED_SITES',
   TOP_SITES_STATE_UPDATED = '@@newtab/TOP_SITES_STATE_UPDATED',
   CUSTOMIZE_CLICKED = '@@newtab/CUSTOMIZE_CLICKED',

components/brave_new_tab_ui/reducers/new_tab_reducer.ts

@@ -92,7 +92,10 @@ export const newTabReducer: Reducer<NewTab.State | undefined> = (state: NewTab.S
       }
       state = storage.addNewStackWidget(state)
       state = storage.replaceStackWidgets(state)
+      break
 
+    case types.NEW_TAB_SET_WIDGET_VISIBILITY_MIGRATION_DATA:
+      state = storage.updateWidgetVisibility(state, payload)
       break
 
     case types.NEW_TAB_STATS_UPDATED:

components/brave_new_tab_ui/storage/new_tab_storage.ts

@@ -4,6 +4,7 @@
 // you can obtain one at http://mozilla.org/MPL/2.0/.
 
 // Utils
+import { saveShowBinance, saveShowCryptoDotCom, saveShowFTX, saveShowGemini, saveWidgetVisibilityMigrated } from '../api/preferences'
 import { debounce } from '../../common/debounce'
 import { loadTimeData } from '../../common/loadTimeData'
 
@@ -28,6 +29,7 @@ export const defaultState: NewTab.State = {
   showBitcoinDotCom: false,
   showCryptoDotCom: false,
   showFTX: false,
+  widgetVisibilityMigrated: false,
   hideAllWidgets: false,
   brandedWallpaperOptIn: false,
   isBrandedWallpaperNotificationDismissed: true,
@@ -240,6 +242,108 @@ export const replaceStackWidgets = (state: NewTab.State) => {
   return state
 }
 
+export const updateWidgetVisibility = (state: NewTab.State, ftxUserAuthed: boolean) => {
+  // Do visibility migration only once.
+  if (state.widgetVisibilityMigrated) {
+    return state
+  }
+
+  const {
+    showRewards,
+    showBraveTalk,
+    braveTalkSupported,
+    showBinance,
+    binanceSupported,
+    showCryptoDotCom,
+    cryptoDotComSupported,
+    showFTX,
+    ftxSupported,
+    showGemini,
+    geminiSupported,
+    binanceState,
+    geminiState
+  } = state
+
+  const widgetLookupTable = {
+    'braveTalk': {
+      display: braveTalkSupported && showBraveTalk,
+      isCrypto: false
+    },
+    'rewards': {
+      display: showRewards,
+      isCrypto: false
+    },
+    'binance': {
+      display: binanceSupported && showBinance,
+      isCrypto: true,
+      userAuthed: binanceState.userAuthed
+    },
+    'cryptoDotCom': {
+      display: cryptoDotComSupported && showCryptoDotCom,
+      isCrypto: true,
+      userAuthed: false
+    },
+    'ftx': {
+      display: ftxSupported && showFTX,
+      isCrypto: true,
+      userAuthed: ftxUserAuthed
+    },
+    'gemini': {
+      display: geminiSupported && showGemini,
+      isCrypto: true,
+      userAuthed: geminiState.userAuthed
+    }
+  }
+
+  // Find crypto widget that is foremost and visible.
+  let foremostVisibleCryptoWidget = ''
+  const lastIndex = state.widgetStackOrder.length - 1
+  for (let i = lastIndex; i >= 0; --i) {
+    const widget = widgetLookupTable[state.widgetStackOrder[i]]
+    if (!widget) {
+      console.error('Update above lookup table')
+      continue
+    }
+
+    if (!widget.display) {
+      continue
+    }
+
+    if (widget.isCrypto) {
+      foremostVisibleCryptoWidget = state.widgetStackOrder[i]
+    }
+    // Found visible foremost widget in the widget stack. Go out.
+    break
+  }
+
+  const widgetsShowKey = {
+    'binance': 'showBinance',
+    'cryptoDotCom': 'showCryptoDotCom',
+    'ftx': 'showFTX',
+    'gemini': 'showGemini'
+  }
+
+  for (let key in widgetsShowKey) {
+    // Show foremost visible crypto widget regardless of auth state
+    // and show user authed crypto widget.
+    if (key === foremostVisibleCryptoWidget ||
+        widgetLookupTable[key].userAuthed) {
+      state[widgetsShowKey[key]] = true
+      continue
+    }
+
+    state[widgetsShowKey[key]] = false
+  }
+
+  saveShowBinance(state.showBinance)
+  saveShowCryptoDotCom(state.showCryptoDotCom)
+  saveShowFTX(state.showFTX)
+  saveShowGemini(state.showGemini)
+  saveWidgetVisibilityMigrated()
+
+  return state
+}
+
 const cleanData = (state: NewTab.State) => {
   const { rewardsState } = state
 

components/definitions/newTab.d.ts

@@ -113,6 +113,7 @@ declare namespace NewTab {
     showBinance: boolean
     showGemini: boolean
     showCryptoDotCom: boolean
+    widgetVisibilityMigrated: boolean
     hideAllWidgets: boolean
     isBraveTodayOptedIn: boolean
     isBrandedWallpaperNotificationDismissed: boolean