Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes whitespace when doing restore #1169

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Fixes whitespace when doing restore #1169

merged 1 commit into from
Dec 21, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 21, 2018 •
edited
Loading

Resolves brave/brave-browser#2665

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • open restore modal
  • past recovery key and add some spaces at the beginning and the end
  • make sure that restore is successful

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Dec 21, 2018
ryanml
ryanml approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix works great

@NejcZdovc NejcZdovc merged commit e503238 into master Dec 21, 2018
@NejcZdovc NejcZdovc deleted the whitespace-restore branch December 21, 2018 17:49
@NejcZdovc
Copy link
Contributor Author

master (0.61) e503238
0.60 f22e813

NejcZdovc added a commit that referenced this pull request Dec 21, 2018
@NejcZdovc
Merge pull request #1169 from brave/whitespace-restore
f22e813 
Fixes whitespace when doing restore
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
@LaurenWags LaurenWags mentioned this pull request Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.

Whitespace at the beginning or end of the recovery key prevents wallet recovery
3 participants
@NejcZdovc @ryanml @bbondy