Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not redirect subresources for non-ipfs pages #11799

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 10, 2022

Resolves brave/brave-browser#20357

Security review https://github.com/brave/security/issues/705

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster requested a review from bbondy January 10, 2022 19:45
@spylogsster spylogsster requested a review from iefremov as a code owner January 10, 2022 19:45
@spylogsster spylogsster self-assigned this Jan 10, 2022
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Jan 10, 2022
@spylogsster spylogsster force-pushed the issue-20357 branch 3 times, most recently from 0d36714 to 963effe Compare January 11, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
3 participants