Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexport guard should match verify_chrome_framework_order, not enable… #11887

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jan 18, 2022

The guard for the unexport list should match verify_chrome_framework_order because that's the check that actually fails without it.

Resolves brave/brave-browser#20547

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver requested a review from bbondy January 18, 2022 20:50
@bridiver bridiver self-assigned this Jan 18, 2022
@goodov
Copy link
Member

goodov commented Jan 19, 2022

noplatform and macos failures are unrelated. going to merge this to rebase my PR.
macos browser tests are currently run slow across all PRs (1hr is not enough).

@goodov goodov merged commit 60fb501 into master Jan 19, 2022
@goodov goodov deleted the unexport-guard branch January 19, 2022 13:37
@goodov goodov added this to the 1.36.x - Nightly milestone Jan 19, 2022
mkarolin pushed a commit that referenced this pull request Jan 25, 2022
unexport guard should match verify_chrome_framework_order, not enable…
mkarolin pushed a commit that referenced this pull request Jan 26, 2022
unexport guard should match verify_chrome_framework_order, not enable…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated build failures for macos x64 asan on nightly
3 participants