-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crlsets with redirector #11917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
reviewed
Jan 20, 2022
browser/net/brave_static_redirect_network_delegate_helper_unittest.cc
Outdated
Show resolved
Hide resolved
iefremov
approved these changes
Jan 20, 2022
goodov
approved these changes
Jan 20, 2022
fmarier
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#20609
For https://github.com/brave/devops/issues/3313
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Use Proxyman (MacOS) or mitmproxy, run the browser with fresh profile using the proxy ( e.g.
--proxy-server="localhost:9090"
), verify:https://dict.brave.com/edgedl/chrome/dict/en-gb-9-0.bdic
(the old request washttps://crlsets.brave.com/edgedl/chrome/dict/en-gb-9-0.bdic
)/edgedl/release2/chrome_component/
,/release2/chrome_component/
,/dl/release2/chrome_component
,/update-delta/hfnkpimlhhgieaddgfemjhofmfblmnib/
,/edgedl/chromewebstore/
,/edgedl/release2/
,/update-delta/ggkkehgbnfjpeggfpleeakpidbkibbmn/
requests are now usinghttps://redirector.brave.com
and all return 200CRLSet