Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bat-native-ads dep #1192

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Bump bat-native-ads dep #1192

merged 1 commit into from
Dec 28, 2018

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 28, 2018

Fix brave/brave-browser#2750

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@tmancey tmancey self-assigned this Dec 28, 2018
@tmancey
Copy link
Collaborator Author

tmancey commented Dec 28, 2018

Fixes brave-intl/bat-native-ads#90
Fixes brave-intl/bat-native-ads#89

mrose17
mrose17 approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 8fe1d8c into master Dec 28, 2018
@tmancey tmancey deleted the issues/2750 branch December 28, 2018 16:08
tmancey added a commit that referenced this pull request Dec 28, 2018
@tmancey
Merge pull request #1192 from /issues/2750
d4106b2 
Bump bat-native-ads dep
@rebron
Copy link
Collaborator

rebron commented Dec 28, 2018

Approving uplift request for 59.x cc: @kjozwiak @srirambv

tmancey added a commit that referenced this pull request Dec 28, 2018
@tmancey
Merge pull request #1192 from /issues/2750
1a7923f 
Bump bat-native-ads dep
@bridiver
Copy link
Collaborator

@tmancey can we start linking to the bat-native-ads changes in these bumps? Or where are we at with moving bat-native-ads into brave-core? Do you need any help with that?

@tmancey
Copy link
Collaborator Author

tmancey commented Dec 29, 2018

@bridiver linked resolved issues in comment above. Currently working on confirmations and as part of the integration with Ads I will move bat-native-ads into Brave Core, thanks

@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrose17 mrose17 mrose17 approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@bbondy bbondy Awaiting requested review from bbondy

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

Bump bat-native-ads dep
6 participants
@tmancey @rebron @bridiver @mrose17 @bbondy @NejcZdovc