Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): disable EIP-1559 on Polygon and Avalanche (uplift to 1.35.x) #11990

Merged
merged 1 commit into from
Jan 27, 2022
Merged

feat(wallet): disable EIP-1559 on Polygon and Avalanche (uplift to 1.35.x) #11990

merged 1 commit into from
Jan 27, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Jan 25, 2022 •
edited by kjozwiak
Loading

Uplift of #11968.
Resolves brave/brave-browser#20652.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@onyb onyb added this to the 1.35.x - Beta milestone Jan 25, 2022
@onyb onyb requested a review from a team January 25, 2022 21:36
@onyb onyb requested a review from a team as a code owner January 25, 2022 21:36
@onyb onyb self-assigned this Jan 25, 2022
@onyb onyb changed the title feat(wallet): disable EIP-1559 on Polygon and Avalanche feat(wallet): disable EIP-1559 on Polygon and Avalanche (uplift to 1.35.x) Jan 25, 2022
@kjozwiak
Copy link
Member

Restarting Android, Linux, macOS & Win x64 using TERMINATE_NODE due to the following:

[2022-01-26T00:39:33.115Z] Recording test results
[2022-01-26T00:39:33.517Z] No test report files were found. Configuration error?
No test report files were found. Configuration error?

@onyb onyb force-pushed the pr11968_f/wallet/eip-1559-polygon-avax_1.35.x branch from eed0a08 to 9632cd1 Compare January 27, 2022 08:43
@onyb
feat(wallet): disable EIP-1559 on Polygon and Avalanche
7789f30 
Our current EIP-1559 gas oracle queries the Etherscan API, which only
supports Ethereum mainnet. As a result, priority fee estimations on
custom networks use results for Ethereum mainnet, which can either
result in transactions being stuck in the mempool forever, or in
over-payment of gas fees.

This commit will be reverted in brave/brave-browser#20469.
@onyb onyb force-pushed the pr11968_f/wallet/eip-1559-polygon-avax_1.35.x branch from 9632cd1 to 7789f30 Compare January 27, 2022 10:27
@kjozwiak kjozwiak mentioned this pull request Jan 27, 2022
Closed
7 tasks
kjozwiak
kjozwiak approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.35.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #11968 (comment).

@kjozwiak kjozwiak merged commit c36cad5 into 1.35.x Jan 27, 2022
@kjozwiak kjozwiak deleted the pr11968_f/wallet/eip-1559-polygon-avax_1.35.x branch January 27, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

Labels
None yet
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@onyb @kjozwiak