Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for desktop mode option #12164

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Feb 7, 2022

Resolves brave/brave-browser#20936

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 7, 2022
@samartnik samartnik added this to the 1.37.x - Nightly milestone Feb 7, 2022
@samartnik samartnik self-assigned this Feb 7, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik
Copy link
Contributor Author

samartnik commented Feb 7, 2022

@simonhong it was a long time ago, but maybe you still remember why we even needed that need_override_ua_?

@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2022

Verification FAILED on Pixel 6 running Android 12 using 1.37.31 Chromium: 98.0.4758.87.

Created brave/brave-browser#20963.

@simonhong
Copy link
Member

@simonhong it was a long time ago, but maybe you still remember why we even needed that need_override_ua_?

I remembered from the commit log :) .

Global desktop mode setting is applied to webcontents only when tab
is created. We can know this by whether checking last committed
entry is null or not.

@samartnik
Copy link
Contributor Author

Thanks for confirming, I reverted these changes and changed detection of tab creation in different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop mode doesn't work always
4 participants