Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows delta updates (uplift to 1.35.x) #12211

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix windows delta updates (uplift to 1.35.x) #12211

merged 1 commit into from
Feb 10, 2022

Conversation

mihaiplesa
Copy link
Collaborator

@mihaiplesa mihaiplesa commented Feb 10, 2022 •
edited
Loading

Uplift of #12098
Resolves brave/brave-browser#18696
Resolves brave/brave-browser#9565

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@mihaiplesa mihaiplesa requested a review from a team as a code owner February 10, 2022 16:11
@mihaiplesa mihaiplesa changed the title Uplift of #12098 (squashed) to release Fix windows delta updates (uplift to 1.35.x) Feb 10, 2022
@mihaiplesa mihaiplesa requested a review from a team February 10, 2022 16:12
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 10, 2022
@github-actions github-actions bot removed the rebase label Feb 10, 2022
@mihaiplesa mihaiplesa added this to the 1.35.x - Release #3 milestone Feb 10, 2022
kjozwiak
kjozwiak approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.35.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 74e7fbf into 1.35.x Feb 10, 2022
@kjozwiak kjozwiak deleted the pr12098_fix-windows-delta-updates_1.35.x branch February 10, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.35.x - Release #3
Development

Successfully merging this pull request may close these issues.
4 participants
@mihaiplesa @kjozwiak @brave-builds @brave-browser-releases