Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear incorrect password to allow user to type new password #12249

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Feb 14, 2022

This PR adds functionality to clear password input when user inputs incorrect password

Resolves brave/brave-browser#21010

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Clear.password.-.wallet.page.mov
Clear.password.-.panel.mov

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 14, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @jamesmudgett to verify
I think we were wanting to clear the field on the next keystroke and not immediately.

@jamesmudgett
Copy link
Collaborator

This is optimal, and better than suggested.

@muliswilliam muliswilliam merged commit c1d6ab8 into master Feb 24, 2022
@muliswilliam muliswilliam deleted the clear-incorrect-password branch February 24, 2022 16:28
@muliswilliam muliswilliam added this to the 1.38.x - Nightly milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear Incorrect Password on Keystroke
4 participants