Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start ledger process and load extension (if needed) before opening Rewards panel (uplift to 1.36.x) #12412

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Start ledger process and load extension (if needed) before opening Rewards panel (uplift to 1.36.x) #12412

merged 1 commit into from
Feb 28, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 25, 2022 •
edited by kjozwiak
Loading

Uplift of #12409
Resolves brave/brave-browser#21311

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 25, 2022 13:59
@brave-builds brave-builds requested review from bsclifton, szilardszaloki and a team and removed request for a team February 25, 2022 13:59
@brave-builds brave-builds self-assigned this Feb 25, 2022
@brave-builds brave-builds added this to the 1.36.x - Release milestone Feb 25, 2022
kjozwiak
kjozwiak approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12409 (comment).

@kjozwiak kjozwiak merged commit 6b771a9 into 1.36.x Feb 28, 2022
@kjozwiak kjozwiak deleted the pr12409_rewards-adaptive-captcha-solve-doesnt-open-panel_1.36.x branch February 28, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton bsclifton is a code owner automatically assigned from brave/rewards-client

@szilardszaloki szilardszaloki Awaiting requested review from szilardszaloki szilardszaloki is a code owner automatically assigned from brave/rewards-client

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases