add support for development signing #1247
Conversation
add support for development signing
| } | ||
| } else { | ||
| # an empty dummy file just to simplify things | ||
| provisioning_profile = "//brave/build/mac/dummy.provisionprofile" |
There was a problem hiding this comment.
This logic is changing; is an empty dummy.provisionprofile OK for non-official builds? (have you tested this code-path?)
There was a problem hiding this comment.
this logic isn't changing, signing never worked for non-official builds. This is in fact the only code path I have tested because I can't test the dev/beta signing
There was a problem hiding this comment.
for dev signing we only pass a provision profile to simplify things with the number of arguments. It isn't actually used in the signing script when --development (below) is passed
| @@ -37,7 +37,7 @@ | |||
| } | |||
|
|
|||
| #if !defined(OFFICIAL_BUILD) | |||
| return "com.brave.Browser.development"; | |||
| return "com.brave.Browser"; | |||
There was a problem hiding this comment.
Why did this need to change? Was it defaulting non-official builds to the dev ID?
There was a problem hiding this comment.
actually this shouldn't be needed. I think it's just leftover from when I couldn't get it to work when everything was set to com.brave.Browser.development. I'll check now
add support for development signing
fix brave/brave-browser#2794
requires brave/brave-browser#2855