Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first run dialog on Windows #12482

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Use first run dialog on Windows #12482

merged 1 commit into from
Mar 14, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 4, 2022

Resolves brave/brave-browser#21464

Below first run dialog is launched if it's fresh install on Windows.
image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Clean install and check first run dialog is launched with checked by default

@simonhong simonhong force-pushed the first_run_on_windows branch 2 times, most recently from 2222dbe to 1e0f6fa Compare March 7, 2022 04:26
@simonhong simonhong marked this pull request as ready for review March 7, 2022 04:28
@simonhong simonhong requested a review from a team as a code owner March 7, 2022 04:28
@github-actions github-actions bot added the rebase label Mar 7, 2022
@simonhong simonhong force-pushed the first_run_on_windows branch from 1e0f6fa to 48cff2f Compare March 7, 2022 04:29
@github-actions github-actions bot removed the rebase label Mar 7, 2022
@simonhong simonhong force-pushed the first_run_on_windows branch from 48cff2f to c2d3f2b Compare March 7, 2022 07:18
@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 7, 2022
@simonhong simonhong force-pushed the first_run_on_windows branch from c2d3f2b to d66fa44 Compare March 7, 2022 08:16
@simonhong simonhong changed the title WIP: Use first run dialog on Windows Use first run dialog on Windows Mar 7, 2022
@simonhong simonhong requested a review from bsclifton March 7, 2022 08:16
browser/ui/BUILD.gn Outdated Show resolved Hide resolved
browser/ui/BUILD.gn Show resolved Hide resolved
browser/ui/BUILD.gn Outdated Show resolved Hide resolved
chromium_src/chrome/browser/first_run/first_run_dialog.h Outdated Show resolved Hide resolved
fix brave/brave-browser#21464
Enabled first run dialog on Windows.
@simonhong simonhong force-pushed the first_run_on_windows branch from d66fa44 to 771d141 Compare March 8, 2022 07:22
@simonhong simonhong merged commit b124ca9 into master Mar 14, 2022
@simonhong simonhong deleted the first_run_on_windows branch March 14, 2022 12:49
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 14, 2022
@bradleyrichter
Copy link
Contributor

@simonhong @rebron This needs a copy update and UI changes according to this new image:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable first run dialog on Windows
3 participants