-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use first run dialog on Windows #12482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
first_run_on_windows
branch
2 times, most recently
from
March 7, 2022 04:26
2222dbe
to
1e0f6fa
Compare
simonhong
force-pushed
the
first_run_on_windows
branch
from
March 7, 2022 04:29
1e0f6fa
to
48cff2f
Compare
simonhong
force-pushed
the
first_run_on_windows
branch
from
March 7, 2022 07:18
48cff2f
to
c2d3f2b
Compare
simonhong
commented
Mar 7, 2022
simonhong
added
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
labels
Mar 7, 2022
simonhong
force-pushed
the
first_run_on_windows
branch
from
March 7, 2022 08:16
c2d3f2b
to
d66fa44
Compare
simonhong
changed the title
WIP: Use first run dialog on Windows
Use first run dialog on Windows
Mar 7, 2022
goodov
reviewed
Mar 7, 2022
fix brave/brave-browser#21464 Enabled first run dialog on Windows.
simonhong
force-pushed
the
first_run_on_windows
branch
from
March 8, 2022 07:22
d66fa44
to
771d141
Compare
goodov
approved these changes
Mar 14, 2022
@simonhong @rebron This needs a copy update and UI changes according to this new image: |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-macos-x64
Do not run CI builds for macOS x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#21464
Below first run dialog is launched if it's fresh install on Windows.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: