Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the dropdown label string 'State level ad targeting' in brave://rewards ads settings #12553

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 9, 2022

Resolves brave/brave-browser#21291

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#21291

@tmancey tmancey requested review from moritzhaller and aseren March 9, 2022 22:19
@tmancey tmancey self-assigned this Mar 9, 2022
@tmancey tmancey added this to the 1.38.x - Nightly milestone Mar 10, 2022
@tmancey tmancey merged commit e96192c into master Mar 10, 2022
@tmancey tmancey deleted the issues/21291 branch March 10, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the dropdown label string 'State level ad targeting' in brave://rewards ads settings
2 participants