Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rewards][Android] Adds pending contributions UI. #12565

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#17038

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Mar 10, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 10, 2022
@mkarolin mkarolin force-pushed the maxk-issue-17038 branch 2 times, most recently from 607dbee to b856186 Compare March 10, 2022 22:48
@mkarolin mkarolin marked this pull request as ready for review March 11, 2022 14:44
@mkarolin mkarolin requested a review from a team as a code owner March 11, 2022 14:44
@mkarolin mkarolin requested review from emerick and deeppandya March 11, 2022 14:44
@mkarolin mkarolin requested a review from zenparsing March 11, 2022 14:45
@github-actions github-actions bot added rebase and removed rebase labels Mar 11, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin
Copy link
Collaborator Author

CI passed. Going to squash the fixup commit and merge.

@mkarolin mkarolin merged commit 3f19432 into master Mar 14, 2022
@mkarolin mkarolin deleted the maxk-issue-17038 branch March 14, 2022 21:25
@mkarolin mkarolin added this to the 1.38.x - Nightly milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add "Show all pending contributions" view
4 participants