Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Windows specific FirstRun dialog #12647

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 17, 2022

Use our own FirstRun dialog on Windows.
No functional change.

fix brave/brave-browser#21694

Screenshot 2022-03-18 121657
Screenshot 2022-03-18 121612

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Mar 17, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Mar 17, 2022
@simonhong simonhong changed the title Prepared for using different FirstRun dialog on Win Use our own FirstRun dialog on Windows Mar 18, 2022
@simonhong simonhong changed the title Use our own FirstRun dialog on Windows Introduced Windows specific FirstRun dialog Mar 18, 2022
@simonhong simonhong marked this pull request as ready for review March 18, 2022 03:21
@simonhong simonhong requested a review from a team as a code owner March 18, 2022 03:21
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 18, 2022
@github-actions github-actions bot removed the rebase label Mar 18, 2022
@simonhong simonhong requested a review from nullhook March 18, 2022 03:25
@simonhong
Copy link
Member Author

cc @bradleyrichter

@bradleyrichter
Copy link
Contributor

looks good @simonhong

Modifed FirstRun dialog is used on macOS/Linux.
And we'll use our own FirstRun dialog on Win.
@simonhong
Copy link
Member Author

Kindly ping @brave/chromium-src-reviewers :)

@simonhong simonhong merged commit 73096ec into master Mar 21, 2022
@simonhong simonhong deleted the first_run_dialog_win branch March 21, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up to first run dialog on Windows
4 participants