Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picked brave vpn button colors based on toolbar color #12675

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 20, 2022

fix brave/brave-browser#21242

VPN Button's colors are selected by choosing most contrasted colors
based on current toolbar color.

Screen Shot 2022-03-20 at 10 08 04 PM Screen Shot 2022-03-20 at 10 08 12 PM Screen Shot 2022-03-20 at 10 08 45 PM
Screen Shot 2022-03-20 at 10 08 17 PM Screen Shot 2022-03-20 at 10 08 32 PM Screen Shot 2022-03-20 at 10 08 24 PM

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable vpn from brave://flags and re-launch
  2. Pick any custom theme at brave://settings/manageProfile and check vpn button's colors

fix brave/brave-browser#21242

VPN Button's colors are selected by choosing most contrasted colors
based on current toolbar color.
@simonhong simonhong requested a review from nullhook March 20, 2022 13:09
@simonhong simonhong self-assigned this Mar 20, 2022
"//components/pref_registry",
"//components/prefs",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more missing deps from brave_theme_helpers.cc

@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 21, 2022
@simonhong simonhong merged commit 1f8ff56 into master Mar 21, 2022
@simonhong simonhong deleted the brave_vpn_button_colors branch March 21, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN button text should be theme/contrast-aware
2 participants