-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phantom de-amp toggle #12694
Fix phantom de-amp toggle #12694
Conversation
9dfc1b9
to
60a6df7
Compare
60a6df7
to
6df22db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we can avoid this template patch / modification entirely by instead placing the amp settings-toggle-button at https://github.com/brave/brave-core/blob/master/browser/resources/settings/brave_privacy_page/brave_personalization_options.html#L56
There's an open issue for the one test failure on Windows: brave/brave-browser#21809, Slack discussion. |
Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup! Please squash away the other commit before merge.
@@ -68,7 +57,7 @@ RegisterPolymerTemplateModifications({ | |||
`) | |||
} | |||
} | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra whitespace
Verification PASSED on
Verified the STR/Cases outline via https://github.com/brave/brave-browser/issues/21788#issue-1175088211%20&%20https://github.com/brave/brave-browser/issues/21788#issuecomment-1074781639. Also ensured that:
|
Resolves brave/brave-browser#21788
Put de-amp setting in brave personalization options.
Screenshots:
(new setting placement)
(no phantom toggle button)
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: