Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): prevent autocomplete for text input element (uplift to 1.36.x) #12773

Closed
wants to merge 1 commit into from
Closed

fix(wallet): prevent autocomplete for text input element (uplift to 1.36.x) #12773

wants to merge 1 commit into from

Conversation

onyb
Copy link
Member

@onyb onyb commented Mar 26, 2022

Uplift of #12756
Resolves brave/brave-browser#21874

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@onyb onyb requested review from diracdeltas, Douglashdaniel and a team March 26, 2022 05:38
@onyb onyb self-assigned this Mar 26, 2022
@onyb onyb added this to the 1.36.x - Release #7 milestone Mar 26, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 26, 2022
@onyb onyb removed the request for review from diracdeltas March 26, 2022 05:38
@onyb onyb changed the title fix(wallet): prevent autocomplete for text input element fix(wallet): prevent autocomplete for text input element (uplift to 1.36.x) Mar 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

Closing 1.36.x doesn't have the feature that's causing the issues. Getting this into 1.37.x next week.

@kjozwiak kjozwiak closed this Mar 26, 2022
@kjozwiak kjozwiak deleted the pr12756_h/wallet/issue-21874_1.36.x branch March 26, 2022 07:14
@kjozwiak kjozwiak removed request for Douglashdaniel and a team March 26, 2022 07:14
@kjozwiak kjozwiak removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 26, 2022
@kjozwiak kjozwiak removed this from the 1.36.x - Release #7 milestone Mar 26, 2022
@kjozwiak kjozwiak restored the pr12756_h/wallet/issue-21874_1.36.x branch March 28, 2022 07:06
@kjozwiak kjozwiak reopened this Mar 28, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 28, 2022
@kjozwiak kjozwiak requested a review from a team March 28, 2022 07:07
@kjozwiak
Copy link
Member

Re-opening in case we need to get a 1.36.x out the door with the above fix if 1.37.x gets delayed.

@kjozwiak kjozwiak assigned brave-builds and unassigned kjozwiak Mar 28, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

Closing as 1.36.x not affected as per @diracdeltas.

@kjozwiak kjozwiak closed this Mar 29, 2022
@kjozwiak kjozwiak deleted the pr12756_h/wallet/issue-21874_1.36.x branch March 29, 2022 16:42
@kjozwiak kjozwiak removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 29, 2022
@kjozwiak kjozwiak removed the request for review from a team March 29, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onyb @brave-builds @kjozwiak